Page MenuHomePhabricator
Differential D12661

[Cashtab] [Simplify wallet structure p7] Patch bug in variable definition
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 05:15.

Details

Reviewers
kieran709
Group Reviewers
Restricted Project
Commits
rABC025294d25f6e: [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition
Summary

T2663

Depends on D12660

Remove artifact wallet state var

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
streamline-wallet-structure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21202
Build 42056: Build Diffcashtab-tests
Build 42055: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 28 2022, 05:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 05:15
bytesofman requested review of this revision.Nov 28 2022, 05:15
Harbormaster completed remote builds in B21202: Diff 36728.Nov 28 2022, 05:18
bytesofman added a child revision: D12662: [Cashtab] [Simplify wallet structure p8] Remove debug logging.Nov 28 2022, 05:21
kieran709 accepted this revision.Nov 28 2022, 23:46
This revision is now accepted and ready to land.Nov 28 2022, 23:46
bytesofman updated this revision to Diff 36808.Nov 30 2022, 08:17

rebase

Harbormaster completed remote builds in B21258: Diff 36808.Nov 30 2022, 08:43
teamcity added a comment.Nov 30 2022, 08:43
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo ======
Error: expect(received).toStrictEqual(expected) // deep equality

Expected: [Error: No token UTXOs for the specified token could be found.]
Received: [TypeError: Cannot destructure property 'tokenId' of 'undefined' as it is undefined.]
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:211:29)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo

bytesofman updated this revision to Diff 36827.Nov 30 2022, 15:56

rebase

Harbormaster completed remote builds in B21275: Diff 36827.Nov 30 2022, 15:59
Closed by commit rABC025294d25f6e: [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition (authored by bytesofman). · Explain WhyDec 1 2022, 07:57
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC025294d25f6e: [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line

Diff 36728

View Options

web/cashtab/src/hooks/useWallet.js

Loading...