Page MenuHomePhabricator

[Cashtab] [deprecate BCH from token send p3] Remove from createToken and related components
ClosedPublic

Authored by bytesofman on Nov 29 2022, 16:20.

Details

Summary

T2730

Depends on D12690

Remove the BCH param from createToken. It is no longer used by the function and is only an artifact.

Also remove in all calls of createToken. The BCH param needs to be removed from this screen in this diff as it is no longer used by any other function there.

Test Plan

npm start
Mint an etoken
grep -r createToken src/ and confirm it is not called anywhere with the BCH param

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-bch-from-sendtoken
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21246
Build 42144: Build Diffcashtab-tests
Build 42143: arc lint + arc unit

Event Timeline

Tail of the build log:

npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-preset-env@7.8.2',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-pseudo-class-any-link@7.1.6',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-selector-not@6.0.1',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }

> cashtab@1.0.0 prepare
> cd ../.. && husky install web/cashtab/.husky

husky - Git hooks installed

added 1813 packages, and audited 1814 packages in 33s

234 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (5 moderate, 2 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 7.7.6 -> 9.1.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
npm notice Run `npm install -g npm@9.1.2` to update!
npm notice 

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/components/Tokens/Tokens.js
  Line 1:17:   'useState' is defined but never used      no-unused-vars
  Line 1:27:   'useEffect' is defined but never used     no-unused-vars
  Line 19:19:  'jestBCH' is missing in props validation  react/prop-types
  Line 19:19:  'jestBCH' is defined but never used       no-unused-vars
  Line 21:9:   'BCH' is assigned a value but never used  no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Removing unused variables to fix build errors

This revision is now accepted and ready to land.Nov 29 2022, 23:42