[Cashtab] [wallet mgmt improvements p1] Add UI locking to settings page
ClosedPublic
Actions

Authored by bytesofman on Dec 10 2022, 18:00.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC5a0745872eb0: [Cashtab] [wallet mgmt improvements p1] Add UI locking to settings page

Summary

T2822

The UI of Configure.js should be locked while async operations that impact wallet data are performed. This diff uses the same approach implemented in Send.js and SendToken.js for locking the UI until the utxo set refreshes. In this case, it is applied to lock the UI until savedWallet state variable has updated.

Test Plan

npm start
Navigate to settings page
Activate a different wallet
In the dev console, note msg savedWallets from useEffect in Configure.js updated, unlocking UI
Test for the same in the extension by building it locally

Diff Detail

Repository

rABC Bitcoin ABC

Branch

stack-to-improve-wallet-mgmt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21508
Build 42664: Build Diff	cashtab-tests
Build 42663: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 10 2022, 18:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2022, 18:00

bytesofman requested review of this revision.Dec 10 2022, 18:00

bytesofman edited the test plan for this revision. (Show Details)Dec 10 2022, 18:01

Harbormaster completed remote builds in B21508: Diff 37180.Dec 10 2022, 18:03

bytesofman added a child revision: D12842: [Cashtab] [wallet mgmt improvements p2] Only update wallet when user has changed wallets.Dec 10 2022, 18:08

the 0.5 second flash of the loading status every 10 seconds is epilepsy inducing... are there any ways around this? e.g. since it flashes for such a tiny fraction of a second can we make it transparent? Otherwise it looks like there's an infinite loop bobbing about in the backend.

This revision now requires changes to proceed.Dec 11 2022, 03:01

In D12841#285894, @emack wrote:

the 0.5 second flash of the loading status every 10 seconds is epilepsy inducing... are there any ways around this? e.g. since it flashes for such a tiny fraction of a second can we make it transparent? Otherwise it looks like there's an infinite loop bobbing about in the backend.

This is corrected later in the stack, where you only get this change on wallet changes or actions and not on update loops

yup just noticed the correction later on in the stack, all good

This revision is now accepted and ready to land.Dec 11 2022, 03:44

Closed by commit rABC5a0745872eb0: [Cashtab] [wallet mgmt improvements p1] Add UI locking to settings page (authored by bytesofman). · Explain WhyDec 11 2022, 05:51

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5a0745872eb0: [Cashtab] [wallet mgmt improvements p1] Add UI locking to settings page.