[Cashtab] [wallet mgmt improvements p9] Patch async function call bug in useEffect
ClosedPublic
Actions

Authored by bytesofman on Dec 10 2022, 18:56.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC28c2ccb7c2a2: [Cashtab] [wallet mgmt improvements p9] Patch async function call bug in…

Summary

T2822

Depends on D12849

updateSavedWallets is an async function and should be called with await in an async useEffect

Test Plan

npm start
go to settings page
change active wallet
Change it back

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 10 2022, 18:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2022, 18:56

bytesofman requested review of this revision.Dec 10 2022, 18:56

bytesofman edited the summary of this revision. (Show Details)Dec 10 2022, 18:56

bytesofman added a parent revision: D12849: [Cashtab] [wallet mgmt improvements p8] Remove or improve debug logging.

Harbormaster completed remote builds in B21518: Diff 37190.Dec 10 2022, 18:59

emack accepted this revision.Dec 11 2022, 05:25

This revision is now accepted and ready to land.Dec 11 2022, 05:25

Closed by commit rABC28c2ccb7c2a2: [Cashtab] [wallet mgmt improvements p9] Patch async function call bug in… (authored by bytesofman). · Explain WhyDec 11 2022, 05:52

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC28c2ccb7c2a2: [Cashtab] [wallet mgmt improvements p9] Patch async function call bug in….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Configure/

Configure.js

4 lines

Diff 37203

View Options

web/cashtab/src/components/Configure/Configure.js

[Cashtab] [wallet mgmt improvements p9] Patch async function call bug in useEffectClosedPublicActions