Page MenuHomePhabricator

Use CTransactionRef where applicable in coins_tests
ClosedPublic

Authored by Fabien on Dec 19 2022, 18:59.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2dd7b54d825e: Use CTransactionRef where applicable in coins_tests
Summary

This avoids doing copies of CTransaction in the tests. This will make the test to work with a non copyable CTransaction.

Also removed the forward declaration of the UpdateCoins function in favor of a proper include. This will prevent the test from failing to build when the prototype changes.

Test Plan
ninja check-bitcoin-coins_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coins_tests_ctransactionref
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21633
Build 42906: Build Diffbuild-debug · build-diff · build-without-wallet · build-clang · lint-circular-dependencies · build-clang-tidy
Build 42905: arc lint + arc unit