Page MenuHomePhabricator

[avalanche] Add the local proof verification status details to getavalancheinfo
ClosedPublic

Authored by Fabien on Dec 27 2022, 17:23.

Details

Summary

The getavalancheinfo RPC returns whether the local proof is verified or not, but gives no indication about why it's not verified. Since the node waits for a block to trigger the verification this can lead to confusion when a user restarts and see his proof being unverified.

This diff adds another status field when the verified field is false to indicate whether the verification is pending or if the verification ocurred but failed.

Test Plan
./test/functional/test_runner.py abc_rpc_getavalancheinfo

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_getavalancheinfo_verified_tristate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21678
Build 42996: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug
Build 42995: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Dec 27 2022, 17:23
Fabien planned changes to this revision.Dec 28 2022, 10:08

There are cases where that info can be wrong, needs to be updated

Handle all the registration failure cases, add another test case, add a release note

This revision is now accepted and ready to land.Dec 29 2022, 21:11