Differential D12946

[cmake] Fix a potential version mismatch in BerkeleyDB
ClosedPublic
Actions

Authored by Fabien on Jan 4 2023, 14:34.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC74a8b93dc589: [cmake] Fix a potential version mismatch in BerkeleyDB

Summary

If several version versions are installed, it is possible for the cmake find package to pick a header that doesn't match the library version. This diff fixes the issue by searching first for the most specific pattern as the library file name.

Test Plan

On Archlinux with both db5.3 and db6.2 installed:

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 4 2023, 14:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 4 2023, 14:34

Fabien requested review of this revision.Jan 4 2023, 14:34

majcosta accepted this revision.Jan 4 2023, 14:53

This revision is now accepted and ready to land.Jan 4 2023, 14:53

Harbormaster completed remote builds in B21694: Diff 37456.Jan 4 2023, 15:04

Closed by commit rABC74a8b93dc589: [cmake] Fix a potential version mismatch in BerkeleyDB (authored by Fabien). · Explain WhyJan 4 2023, 15:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC74a8b93dc589: [cmake] Fix a potential version mismatch in BerkeleyDB.

Revision Contents
Changeset List

Path

Size

cmake/

modules/

FindBerkeleyDB.cmake

7 lines

Diff 37457

View Options

cmake/modules/FindBerkeleyDB.cmake

[cmake] Fix a potential version mismatch in BerkeleyDBClosedPublicActions