Differential D12959

remove IsValidWithoutConfig and CheckHeaderMagicAndCommand
AbandonedPublicDraft
Actions

Authored by majcosta on Jan 6 2023, 16:19.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

these were introduced in D7146, but with core#19107 oversized header
checks are now performed in V1TransportSerializer

Depends on D12956 and D12958

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cleanup_d7146

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21716
Build 43072: Build Diff	lint-circular-dependencies · build-without-wallet · build-clang · build-debug · build-clang-tidy · build-diff
Build 43071: arc lint + arc unit

Event Timeline

majcosta created this revision.Jan 6 2023, 16:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2023, 16:19

teamcity edited the summary of this revision. (Show Details)Jan 6 2023, 16:19

Harbormaster completed remote builds in B21713: Diff 37481.Jan 6 2023, 16:24

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[412/480] bitcoin: testing blockfilter_tests
[413/480] Running utility command for check-bitcoin-key_io_tests
[414/480] Running utility command for check-bitcoin-blockfilter_tests
[415/480] Running utility command for check-bitcoin-scheduler_tests
[416/480] bitcoin: testing coinstatsindex_tests
[417/480] Running utility command for check-bitcoin-coinstatsindex_tests
[418/480] bitcoin: testing walletdb_tests
[419/480] bitcoin: testing script_tests
[420/480] Running utility command for check-bitcoin-walletdb_tests
[421/480] bitcoin: testing sigencoding_tests
[422/480] Running utility command for check-bitcoin-script_tests
[423/480] Running utility command for check-bitcoin-sigencoding_tests
[424/480] bitcoin: testing txvalidationcache_tests
[425/480] bitcoin: testing intmath_tests
[426/480] Running utility command for check-bitcoin-txvalidationcache_tests
[427/480] Running utility command for check-bitcoin-intmath_tests
[428/480] bitcoin: testing merkle_tests
[429/480] bitcoin: testing blockindex_tests
[430/480] Running utility command for check-bitcoin-merkle_tests
[431/480] Running utility command for check-bitcoin-blockindex_tests
[432/480] bitcoin: testing miner_tests
[433/480] bitcoin: testing mempool_tests
[434/480] Running utility command for check-bitcoin-miner_tests
[435/480] Running utility command for check-bitcoin-mempool_tests
[436/480] bitcoin: testing rcu_tests
[437/480] bitcoin: testing init_tests
[438/480] Running utility command for check-bitcoin-rcu_tests
[439/480] bitcoin: testing denialofservice_tests
[440/480] Running utility command for check-bitcoin-init_tests
[441/480] Running utility command for check-bitcoin-denialofservice_tests
[442/480] bitcoin: testing scriptnum_tests
[443/480] bitcoin: testing bitmanip_tests
[444/480] bitcoin: testing uint256_tests
[445/480] Running utility command for check-bitcoin-scriptnum_tests
[446/480] Running utility command for check-bitcoin-bitmanip_tests
[447/480] Running utility command for check-bitcoin-uint256_tests
[448/480] bitcoin: testing cuckoocache_tests
[449/480] bitcoin: testing crypto_tests
[450/480] Running utility command for check-bitcoin-cuckoocache_tests
[451/480] Running utility command for check-bitcoin-crypto_tests
[452/480] bitcoin: testing wallet_crypto_tests
[453/480] Running utility command for check-bitcoin-wallet_crypto_tests
[454/480] bitcoin: testing txrequest_tests
[455/480] Running utility command for check-bitcoin-txrequest_tests
[456/480] bitcoin: testing radix_tests
[457/480] Running utility command for check-bitcoin-radix_tests
[458/480] bitcoin: testing blockcheck_tests
[459/480] Running utility command for check-bitcoin-blockcheck_tests
[460/480] bitcoin: testing coinselector_tests
[461/480] Running utility command for check-bitcoin-coinselector_tests
[462/480] bitcoin: testing wallet_tests
[463/480] Running utility command for check-bitcoin-wallet_tests
[464/480] bitcoin: testing transaction_tests
[465/480] Running utility command for check-bitcoin-transaction_tests
[466/480] bitcoin: testing coins_tests
[467/480] Running utility command for check-bitcoin-coins_tests
[468/480] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[0m[1;30mwallet_labels.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py --descriptors            | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                  | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                  | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py --descriptors    | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py --descriptors  | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli            | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py        | ○ Skipped | 0 s
[0m[1;30mwallet_send.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_startup.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock           | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock     | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli              | ○ Skipped | 0 s
[0m[1m
ALL                                       | ✓ Passed  | 726 s (accumulated) 
[0mRuntime: 145 s

[172/441] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
FAILED: src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBOOST_THREAD_DYN_LINK -DBOOST_UNIT_TEST_FRAMEWORK_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o -MF src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o.d -o src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o -c ../../src/seeder/test/p2p_messaging_tests.cpp
../../src/seeder/test/p2p_messaging_tests.cpp: In member function ‘void p2p_messaging_tests::process_verack_msg::test_method()’:
../../src/seeder/test/p2p_messaging_tests.cpp:101:40: error: variable ‘netMagic’ set but not used [-Werror=unused-but-set-variable]
  101 |     const CMessageHeader::MessageMagic netMagic = Params().NetMagic();
      |                                        ^~~~~~~~
cc1plus: all warnings being treated as errors
[176/441] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[178/441] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[181/441] Running pow test suite
PASSED: pow test suite
[185/441] Running avalanche test suite
PASSED: avalanche test suite
[194/441] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[195/441] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
  540 | BOOST_AUTO_TEST_CASE(script_build) {
      |                      ^~~~~~~~~~~~
[428/441] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[0;32mwallet_keypool_topup.py --descriptors     | ✓ Passed  | 6 s
[0m[0;32mwallet_labels.py                          | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py --descriptors            | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                  | ✓ Passed  | 9 s
[0m[0;32mwallet_listsinceblock.py                  | ✓ Passed  | 10 s
[0m[0;32mwallet_listsinceblock.py --descriptors    | ✓ Passed  | 11 s
[0m[0;32mwallet_listtransactions.py                | ✓ Passed  | 5 s
[0m[0;32mwallet_listtransactions.py --descriptors  | ✓ Passed  | 5 s
[0m[0;32mwallet_multiwallet.py                     | ✓ Passed  | 56 s
[0m[0;32mwallet_multiwallet.py --usecli            | ✓ Passed  | 16 s
[0m[0;32mwallet_reorgsrestore.py                   | ✓ Passed  | 4 s
[0m[0;32mwallet_resendwallettransactions.py        | ✓ Passed  | 8 s
[0m[0;32mwallet_send.py                            | ✓ Passed  | 8 s
[0m[0;32mwallet_startup.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                 | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli              | ✓ Passed  | 1 s
[0m[1;30mchronik_serve.py                          | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                     | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py               | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py              | ○ Skipped | 0 s
[0m[1m
ALL                                       | ✓ Passed  | 2086 s (accumulated) 
[0mRuntime: 417 s

[160/481] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
FAILED: src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBOOST_THREAD_DYN_LINK -DBOOST_UNIT_TEST_FRAMEWORK_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIE -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o -MF src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o.d -o src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o -c ../../src/seeder/test/p2p_messaging_tests.cpp
../../src/seeder/test/p2p_messaging_tests.cpp: In member function ‘void p2p_messaging_tests::process_verack_msg::test_method()’:
../../src/seeder/test/p2p_messaging_tests.cpp:101:40: error: variable ‘netMagic’ set but not used [-Werror=unused-but-set-variable]
  101 |     const CMessageHeader::MessageMagic netMagic = Params().NetMagic();
      |                                        ^~~~~~~~
cc1plus: all warnings being treated as errors
[197/481] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[198/481] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.002s

OK
[206/481] Running pow test suite
PASSED: pow test suite
[440/481] Running avalanche test suite
PASSED: avalanche test suite
[455/481] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[461/481] Running secp256k1 test suite
PASSED: secp256k1 test suite
[468/481] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_abandonconflict.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_address_types.py                   | ✓ Passed  | 13 s
[0m[0;32mwallet_address_types.py --descriptors     | ✓ Passed  | 9 s
[0m[0;32mwallet_avoidreuse.py                      | ✓ Passed  | 4 s
[0m[0;32mwallet_avoidreuse.py --descriptors        | ✓ Passed  | 4 s
[0m[0;32mwallet_backup.py                          | ✓ Passed  | 24 s
[0m[0;32mwallet_balance.py                         | ✓ Passed  | 6 s
[0m[0;32mwallet_balance.py --descriptors           | ✓ Passed  | 6 s
[0m[0;32mwallet_basic.py                           | ✓ Passed  | 16 s
[0m[0;32mwallet_coinbase_category.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                       | ✓ Passed  | 5 s
[0m[0;32mwallet_createwallet.py                    | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --descriptors      | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli           | ✓ Passed  | 2 s
[0m[0;32mwallet_descriptor.py                      | ✓ Passed  | 5 s
[0m[0;32mwallet_disable.py                         | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                            | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py                      | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py --descriptors        | ✓ Passed  | 5 s
[0m[0;32mwallet_groups.py                          | ✓ Passed  | 13 s
[0m[0;32mwallet_hd.py                              | ✓ Passed  | 7 s
[0m[0;32mwallet_hd.py --descriptors                | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                   | ✓ Passed  | 9 s
[0m[0;32mwallet_import_with_label.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py               | ✓ Passed  | 6 s
[0m[0;32mwallet_importmulti.py                     | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_importprunedfunds.py --descriptors | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py --descriptors     | ✓ Passed  | 5 s
[0m[0;32mwallet_labels.py                          | ✓ Passed  | 1 s
[0m[0;32mwallet_labels.py --descriptors            | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                  | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py                  | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py --descriptors    | ✓ Passed  | 7 s
[0m[0;32mwallet_listtransactions.py                | ✓ Passed  | 5 s
[0m[0;32mwallet_listtransactions.py --descriptors  | ✓ Passed  | 4 s
[0m[0;32mwallet_multiwallet.py                     | ✓ Passed  | 39 s
[0m[0;32mwallet_multiwallet.py --usecli            | ✓ Passed  | 10 s
[0m[0;32mwallet_reorgsrestore.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py        | ✓ Passed  | 5 s
[0m[0;32mwallet_send.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_startup.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                 | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli              | ✓ Passed  | 1 s
[0m[1;30mchronik_serve.py                          | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                     | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py               | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py              | ○ Skipped | 0 s
[0m[1m
ALL                                       | ✓ Passed  | 1238 s (accumulated) 
[0mRuntime: 248 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

nice catch, gcc

Harbormaster completed remote builds in B21716: Diff 37484.Jan 6 2023, 17:35

this is no good