Page MenuHomePhabricator
Differential D7146

Clean up separated ban/discourage interface
ClosedPublic
Actions

Authored by jasonbcox on Aug 7 2020, 00:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3c30539ab667: Clean up separated ban/discourage interface
Summary

This completes the backport of Core PR19219, the last commit being delayed due to missing
dependant backports.

https://github.com/bitcoin/bitcoin/pull/19219/commits/2ad58381fffb33d611abf900b73d9e6b5a4e35f8

Test Plan
ninja check check-functional

cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja bitcoin-fuzzers
./src/test/fuzz/addrdb

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 7 2020, 00:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 00:13
jasonbcox requested review of this revision.Aug 7 2020, 00:13
teamcity edited the summary of this revision. (Show Details)Aug 7 2020, 00:13

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added inline comments.Aug 7 2020, 00:17
src/net_processing.cpp
3964 ↗(On Diff #22789)

We're missing a backport here that prevents me from including the rename CheckIfBanned -> MaybeDiscourageAndDisconnect but I don't think it's consequential enough to hold this change back. We'll catch up to the name change eventually.

src/test/fuzz/addrdb.cpp
19 ↗(On Diff #22789)

This is my removal for two reasons:

  1. It's unused now.
  2. It's being shadowed within the lambda.
Harbormaster completed remote builds in B12329: Diff 22789.Aug 7 2020, 00:28
deadalnix accepted this revision.Aug 7 2020, 14:35
This revision is now accepted and ready to land.Aug 7 2020, 14:35
Closed by commit rABC3c30539ab667: Clean up separated ban/discourage interface (authored by Pieter Wuille <pieter@wuille.net>, committed by jasonbcox). · Explain WhyAug 7 2020, 15:47
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC3c30539ab667: Clean up separated ban/discourage interface.
PiRK mentioned this in D8392: [backport#17850] Convert addrdb/addrman to new serialization.Nov 13 2020, 12:59
PiRK mentioned this in rABCe59a7e12537a: [backport#17850] Convert addrdb/addrman to new serialization.Nov 13 2020, 15:08
Fabien mentioned this in D8791: Rename CheckIfBanned() to MaybeDiscourageAndDisconnect().Jan 5 2021, 13:32
Fabien mentioned this in rABC6176f87a9d44: Rename CheckIfBanned() to MaybeDiscourageAndDisconnect().Jan 6 2021, 10:47
majcosta mentioned this in D12959: remove IsValidWithoutConfig and CheckHeaderMagicAndCommand.Jan 6 2023, 16:19

Revision Contents
Changeset List

PathSize
src/
28 lines
22 lines
53 lines
interfaces/
3 lines
5 lines
16 lines
2 lines
35 lines
qt/
2 lines
rpc/
11 lines
test/
22 lines
fuzz/
16 lines

Diff 22790

View Options

src/addrdb.h

Loading...
View Options

src/banman.h

Loading...
View Options

src/banman.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_permissions.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/fuzz/addrdb.cpp

Loading...