Differential D12975

[avalanche] Move the vote items to the update structure
ClosedPublic
Actions

Authored by Fabien on Jan 12 2023, 16:29.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC340aa9a73c35: [avalanche] Move the vote items to the update structure

Summary

The VoteItemUpdate constructor moves the item, but this item is const.
Fix the code to properly move the item where applicable.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_voteitem_nonconst

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21737
Build 43113: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43112: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 12 2023, 16:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2023, 16:29

Fabien requested review of this revision.Jan 12 2023, 16:29

PiRK accepted this revision.Jan 12 2023, 16:48

This revision is now accepted and ready to land.Jan 12 2023, 16:48

Harbormaster completed remote builds in B21737: Diff 37521.Jan 12 2023, 16:56

Closed by commit rABC340aa9a73c35: [avalanche] Move the vote items to the update structure (authored by Fabien). · Explain WhyJan 12 2023, 17:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC340aa9a73c35: [avalanche] Move the vote items to the update structure.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

2 lines

processor.cpp

13 lines

Diff 37521

View Options

src/avalanche/processor.h