Differential D13042

[avalanche] Fix type error in abc_p2p_avalanche_peer_discovery
ClosedPublic
Actions

Authored by Fabien on Jan 24 2023, 10:36.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf7a1adfb8971: [avalanche] Fix type error in abc_p2p_avalanche_peer_discovery

Summary

The inv field of a getdata message is actually a list. The method was unused so the test didn't fail, but it will be used in D13029.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_peer_discovery

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fix_inv_list

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21839
Build 43313: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 43312: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2023, 10:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2023, 10:36

Fabien requested review of this revision.Jan 24 2023, 10:36

PiRK accepted this revision.Jan 24 2023, 11:06

This revision is now accepted and ready to land.Jan 24 2023, 11:06

Harbormaster completed remote builds in B21839: Diff 37673.Jan 24 2023, 11:13

Closed by commit rABCf7a1adfb8971: [avalanche] Fix type error in abc_p2p_avalanche_peer_discovery (authored by Fabien). · Explain WhyJan 24 2023, 12:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf7a1adfb8971: [avalanche] Fix type error in abc_p2p_avalanche_peer_discovery.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_peer_discovery.py

5 lines

Diff 37673

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

[avalanche] Fix type error in abc_p2p_avalanche_peer_discoveryClosedPublicActions