util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE macro
ClosedPublic
Actions

Authored by PiRK on Feb 2 2023, 14:48.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCaac98988ac21: util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE…

Summary

This is a backport of core#24812

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21917
Build 43469: Build Diff	build-diff · lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-debug · build-clang
Build 43468: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 2 2023, 14:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2023, 14:48

PiRK requested review of this revision.Feb 2 2023, 14:48

teamcity edited the summary of this revision. (Show Details)Feb 2 2023, 14:48

PiRK added a child revision: D13097: refactor: Introduce GetFirstStoredBlock helper function.Feb 2 2023, 14:49

Harbormaster completed remote builds in B21917: Diff 37796.Feb 2 2023, 15:03

Looks like the title refers to an extra "UNREACHABLE" that is not there. Please fix before landing.

This revision is now accepted and ready to land.Feb 2 2023, 19:12

PiRK retitled this revision from util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros to util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE macro.Feb 2 2023, 19:19

Closed by commit rABCaac98988ac21: util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE… (authored by Aurèle Oulès <aurele@oules.com>, committed by PiRK). · Explain WhyFeb 3 2023, 07:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCaac98988ac21: util/check: Add CHECK_NONFATAL identity function and a NONFATAL_UNREACHABLE….