Page MenuHomePhabricator
Differential D13098

Call CHECK_NONFATAL only once where needed
ClosedPublic
Actions

Authored by PiRK on Feb 2 2023, 14:53.

Details

Reviewers
sdulfari
Fabien
Group Reviewers
Restricted Project
Commits
rABC1203360d8a45: Call CHECK_NONFATAL only once where needed
Summary

This is a backport of core#24956

Depends on D13097

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 2 2023, 14:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2023, 14:53
PiRK requested review of this revision.Feb 2 2023, 14:53
teamcity edited the summary of this revision. (Show Details)Feb 2 2023, 14:53
Harbormaster completed remote builds in B21919: Diff 37798.Feb 2 2023, 15:14
sdulfari requested changes to this revision.Feb 2 2023, 19:44
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/rpc/blockchain.cpp
1895 ↗(On Diff #37798)

cleanup to match the backport

This revision now requires changes to proceed.Feb 2 2023, 19:44
PiRK updated this revision to Diff 37814.Feb 3 2023, 07:27

remove unnecessary double cast, GetDifficulty already returns a double

Harbormaster completed remote builds in B21933: Diff 37814.Feb 3 2023, 08:04
Fabien accepted this revision.Feb 5 2023, 12:02
sdulfari accepted this revision.Feb 7 2023, 00:38
This revision is now accepted and ready to land.Feb 7 2023, 00:38
Closed by commit rABC1203360d8a45: Call CHECK_NONFATAL only once where needed (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyFeb 14 2023, 07:11
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1203360d8a45: Call CHECK_NONFATAL only once where needed.

Revision Contents
Changeset List

PathSize
src/
rpc/
24 lines

Diff 37882

View Options

src/rpc/blockchain.cpp

Loading...