Differential D13076

[Explorer] fix copy address issue
ClosedPublic
Actions

Authored by johnkuney on Jan 30 2023, 21:23.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1d770f3a3338: [Explorer] fix copy address issue

Summary

On any address page, the copy button was adding some extra spacing. Fixed by removing some unecessary if rendering

Test Plan

run the app and see if the copy address button works properly

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D13076

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21954
Build 43543: Build Diff
Build 43542: arc lint + arc unit

Event Timeline

johnkuney created this revision.Jan 30 2023, 21:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2023, 21:23

johnkuney requested review of this revision.Jan 30 2023, 21:23

Harbormaster completed remote builds in B21893: Diff 37761.Jan 30 2023, 21:23

Fabien requested changes to this revision.Feb 5 2023, 10:15

Fabien added a subscriber: Fabien.

Fabien added inline comments.

web/explorer/explorer-server/templates/pages/address.html
10 ↗	(On Diff #37761)	It's indeed fixing the copy spacing issues, but it's also removing a feature since it won't display the etoken address anymore. This is confusing as a search for an etoken address now returns an ecash address, which is unexpected.
161 ↗	(On Diff #37761)	That's an unrelated change

This revision now requires changes to proceed.Feb 5 2023, 10:15

reverting removing the if logic as it removed some functionaility. Trying adjusting the code spacing

Harbormaster completed remote builds in B21951: Diff 37838.Feb 7 2023, 16:41

i tried adjusting the spacing in the code that is causing this but the linter wont allow it...

web/explorer/explorer-server/templates/pages/address.html
161 ↗	(On Diff #37761)	I believe that was an auto format change...

Move the if logic out of the h2 element

Harbormaster completed remote builds in B21953: Diff 37841.Feb 7 2023, 16:52

remove extra h2 tag

Harbormaster completed remote builds in B21954: Diff 37842.Feb 7 2023, 16:53

Fabien accepted this revision.Feb 7 2023, 18:50

This revision is now accepted and ready to land.Feb 7 2023, 18:50

Closed by commit rABC1d770f3a3338: [Explorer] fix copy address issue (authored by johnkuney). · Explain WhyFeb 7 2023, 23:28

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC1d770f3a3338: [Explorer] fix copy address issue.

Revision Contents
Changeset List

Path

Size

web/

explorer/

explorer-server/

templates/

pages/

18 lines

Diff 37842

web/explorer/explorer-server/templates/pages/address.html

Loading...