Paths

Table of Contentst

Differential D1358

[cmake] Use Boost_THREADAPI to select the flavor of the thread API we want to use on windows
ClosedPublic
Actions

Authored by deadalnix on May 2 2018, 21:52.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGING3fa51d1b0635: [cmake] Use Boost_THREADAPI to select the flavor of the thread API we want to…
rABC3fa51d1b0635: [cmake] Use Boost_THREADAPI to select the flavor of the thread API we want to…

Summary

This is the proper way to do it. Also updated the depends build to make sure the right dependencies are included.

Test Plan

Build with ninja on linux + cross compilation on windows 32 and 64.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

winboost

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2520
Build 3160: Bitcoin ABC Buildbot (legacy)
Build 3159: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 2 2018, 21:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2018, 21:52

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2474: Diff 3727.May 2 2018, 22:14

"This is the proper way to do it. "

What is it?

Ping ?

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster failed remote builds in B2520: Diff 3785!May 5 2018, 21:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel accepted this revision.May 7 2018, 05:41

This revision is now accepted and ready to land.May 7 2018, 05:41

Closed by commit rABC3fa51d1b0635: [cmake] Use Boost_THREADAPI to select the flavor of the thread API we want to… (authored by deadalnix). · Explain WhyMay 7 2018, 11:31

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

depends/

packages/

boost.mk

2 lines

src/

CMakeLists.txt

13 lines

Diff 3785

View Options

depends/packages/boost.mk