[alias-server] [p15] Only add alias records if alias is unique
ClosedPublic
Actions

Authored by bytesofman on Feb 21 2023, 23:49.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC7e653cea3642: [alias-server] [p15] Only add alias records if alias is unique

Summary

T2922

Depends on D13151

Only add alias records that are not already in the database

Test Plan

sudo systemctl start mongod
In mongod, delete the ecashAliases database:

use ecashAliases
db.dropDatabase()

Run node index.js in web/alias-server
Note aliases are added to database
Run node index.js again
Note no aliases are added but all are processed

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alias-node-app

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22049
Build 43733: Build Diff
Build 43732: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 21 2023, 23:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2023, 23:49

bytesofman requested review of this revision.Feb 21 2023, 23:49

Harbormaster completed remote builds in B22049: Diff 37975.Feb 21 2023, 23:49

bytesofman added a child revision: D13162: [alias-server] [p16] Update database on block.Feb 23 2023, 01:03

after dropping the db in mongosh, running node index.js to insert the aliases and then running node index.js a second time, I'm still seeing insertedCount as 131.

This revision now requires changes to proceed.Feb 24 2023, 05:17

In D13152#292465, @emack wrote:

after dropping the db in mongosh, running node index.js to insert the aliases and then running node index.js a second time, I'm still seeing insertedCount as 131.

Tracked via T2947

This revision is now accepted and ready to land.Feb 24 2023, 20:31

Closed by commit rABC7e653cea3642: [alias-server] [p15] Only add alias records if alias is unique (authored by bytesofman). · Explain WhyFeb 28 2023, 22:46

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC7e653cea3642: [alias-server] [p15] Only add alias records if alias is unique.