util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli
ClosedPublic
Actions

Authored by PiRK on Feb 27 2023, 16:50.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC36613b39a363: util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli

Summary

If bitcoind is processing 16 RPC requests, attempting to submit another request using bitcoin-cli produces this less-than-helpful error message: error: couldn't parse reply from server. This PR changes the error to: error: server response: Work queue depth exceeded.

This is a backport of core#18335 and core#21484

Test Plan

$ src/bitcoind -rpcworkqueue=1 -daemonwait=1
$ sleep 10
$ seq 10 | while read i;do src/bitcoin-cli getblockchaininfo  >/dev/null&done
error: Server response: Work queue depth exceeded
error: Server response: Work queue depth exceeded
$ src/bitcoin-cli stop

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18335

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22121
Build 43877: Build Diff	build-diff · build-debug · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang
Build 43876: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 27 2023, 16:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2023, 16:50

PiRK requested review of this revision.Feb 27 2023, 16:50

teamcity edited the summary of this revision. (Show Details)Feb 27 2023, 16:50

PiRK added inline comments.Feb 27 2023, 16:54

test/functional/interface_rpc.py
98 ↗	(On Diff #38077)	I suspect that using multiple threads here does not achieve anything, due to python's limitations with multithreading. But it does not hurt either, and maybe a future version of python will actually be able to do proper multithreading.