[Cashtab] [Alias] - Alias address preview upon valid input
ClosedPublic
Actions

Authored by emack on Mar 11 2023, 14:04.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf992b5fec924: [Cashtab] [Alias] - Alias address preview upon valid input

Summary

T2989

Upon input of a valid alias in send xec and send token components, the parsed address is displayed beneath the address input as a preview for the user for verification purposes.

Test Plan

navigate to Send, input a valid alias and ensure the address preview message is displayed This alias resolves to...
add one extra character to invalidate the alias input and ensure the address preview is cleared and Invalid address is displayed
remove the one extra character from above and ensure address preview is displayed again
replace the alias input with a valid ecash address and ensure no address preview nor error is displayed
use an invalid ecash address and ensure Invalid address is displayed
enter a valid alias and send a normal XEC transaction. Ensure upon successful broadcast the address preview message is cleared
repeat the above for sendToken

Diff Detail

Repository

rABC Bitcoin ABC

Branch

aliasAddressPreview

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22373
Build 44372: Build Diff	cashtab-tests
Build 44371: arc lint + arc unit

Event Timeline

emack created this revision.Mar 11 2023, 14:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2023, 14:04

emack requested review of this revision.Mar 11 2023, 14:04

Harbormaster completed remote builds in B22367: Diff 38437.Mar 11 2023, 14:16

Looks good. Just a copy change.

web/cashtab/src/components/Send/Send.js
786 ↗	(On Diff #38437)	I don't think we need to spell it out so hard. Just including `${aliasInputAddress.slice...}` is enough, remove "This alias resolves to "