Make CTxIn and CTxOut constructors defined inline
ClosedPublic
Actions

Authored by deadalnix on May 9 2018, 14:14.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1d55e4ff295c: Make CTxIn and CTxOut constructors defined inline
rABC1d55e4ff295c: Make CTxIn and CTxOut constructors defined inline

Summary

They aresimple ctors that pass data back and forth, so no point in preventing the compiler to optimize them away.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txinoutctor

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2566
Build 3249: Bitcoin ABC Buildbot (legacy)
Build 3248: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 9 2018, 14:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 9 2018, 14:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2566: Diff 3853.May 9 2018, 14:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

jasonbcox accepted this revision.May 9 2018, 20:46

This revision is now accepted and ready to land.May 9 2018, 20:46

Closed by commit rABC1d55e4ff295c: Make CTxIn and CTxOut constructors defined inline (authored by deadalnix). · Explain WhyMay 9 2018, 20:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

primitives/

transaction.h

9 lines

transaction.cpp

18 lines

Diff 3853

View Options

src/primitives/transaction.h