Paths

Table of Contentst

Differential D13343

[chronik websockets] Deprecate onReconnect logs for node server apps
ClosedPublic
Actions

Authored by bytesofman on Mar 15 2023, 15:37.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC416bedd50779: [chronik websockets] Deprecate onReconnect logs for node server apps

Summary

T3005

This statement isn't doing anything but providing information. Websockets frequently disconnect and reconnect. Remove to clear up debug logs.

Test Plan

node index.js in both apps, wait for one block, behaves as normal.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

websocket-reconnect-log-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22469
Build 44563: Build Diff
Build 44562: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 15 2023, 15:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2023, 15:37

bytesofman requested review of this revision.Mar 15 2023, 15:37

Harbormaster completed remote builds in B22469: Diff 38600.Mar 15 2023, 15:38

emack accepted this revision.Mar 16 2023, 05:06

This revision is now accepted and ready to land.Mar 16 2023, 05:06

Closed by commit rABC416bedd50779: [chronik websockets] Deprecate onReconnect logs for node server apps (authored by bytesofman). · Explain WhyMar 16 2023, 11:54

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC416bedd50779: [chronik websockets] Deprecate onReconnect logs for node server apps.

Revision Contents
Changeset List

Path

Size

web/

alias-server/

websocket.js

4 lines

ecash-telegram-bot/

chronik.js

4 lines

Diff 38600

View Options

web/alias-server/websocket.js