Differential D13459

build: Disallow dynamic linking against c++ library
ClosedPublic
Actions

Authored by PiRK on Mar 24 2023, 15:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9461b3d98c1a: build: Disallow dynamic linking against c++ library

Summary

Ever since statically linking Qt, we've been linking the C++ library
statically too (-static-libstdc++). Take this into
account in the symbol checker.

This is a partial backport of core#17569
https://github.com/bitcoin/bitcoin/pull/17569/commits/b77d5ad59fb9f3f26d919ee6c33ae732382de504

Test Plan

gitian builds on CI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 24 2023, 15:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2023, 15:27

PiRK requested review of this revision.Mar 24 2023, 15:27

teamcity edited the summary of this revision. (Show Details)Mar 24 2023, 15:27

Harbormaster completed remote builds in B22667: Diff 38849.Mar 24 2023, 15:27

@bot gitian-linux gitian-win gitian-osx

teamcity awarded a token.Mar 24 2023, 15:28

PiRK added a child revision: D13460: [symbol-check] bump glibc to 2.27 and gcc to 8.3.Mar 24 2023, 15:30

Fabien accepted this revision.Mar 24 2023, 15:37

This revision is now accepted and ready to land.Mar 24 2023, 15:37

Closed by commit rABC9461b3d98c1a: build: Disallow dynamic linking against c++ library (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by PiRK). · Explain WhyMar 25 2023, 16:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9461b3d98c1a: build: Disallow dynamic linking against c++ library.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

symbol-check.py

9 lines

Diff 38893

View Options

contrib/devtools/symbol-check.py

build: Disallow dynamic linking against c++ libraryClosedPublicActions