Paths

Table of Contentst

Differential D13467

[Chronik] Index txs; add `/tx/:txid` HTTP endpoint
ClosedPublic
Actions

Authored by tobias_ruck on Mar 25 2023, 21:50.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9514a0915212: [Chronik] Index txs; add `/tx/:txid` HTTP endpoint

Summary

We add transactions to the DB as new blocks are coming in using TxWriter. Until we index the mempool, we set the time_first_seen to 0.

/tx/:txid returns txs by txid from the DB using the QueryTxs struct; not from the mempool yet though, which will be in a future diff.

We also add a few new protobuf messages: Tx, OutPoint, TxInput, TxOutput, BlockMetadata and Network.

Test Plan

ninja check-crates && ninja && ./test/functional/test_runner.py chronik_tx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-tx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22716
Build 45052: Build Diff	build-without-wallet · build-diff · build-chronik · build-clang · build-debug · build-clang-tidy
Build 45051: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 25 2023, 21:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2023, 21:50

tobias_ruck requested review of this revision.Mar 25 2023, 21:50

Harbormaster completed remote builds in B22704: Diff 38898.Mar 25 2023, 22:04

tobias_ruck added a child revision: D13468: [Chronik] Add `Mempool`, make `/tx/:txid` return mempool txs.Mar 25 2023, 23:21

Factor out connect_block and disconnect_block, include block hash and num txs in log

Harbormaster completed remote builds in B22716: Diff 38912.Mar 27 2023, 10:35

Fabien requested changes to this revision.Mar 27 2023, 14:35

Fabien added inline comments.

chronik/chronik-indexer/src/query/txs.rs
50–55	Nit: no need to instanciate a block reader if the tx is not found
chronik/chronik-proto/proto/chronik.proto
48	What's the use for that one ? Is there any chronik instance that can index several chains ?
test/functional/chronik_tx.py
28
171	dito

This revision now requires changes to proceed.Mar 27 2023, 14:35

Remove 'network' field from proto; small nits

Harbormaster completed remote builds in B22732: Diff 38929.Mar 27 2023, 16:13

Fabien accepted this revision.Mar 27 2023, 16:17

This revision is now accepted and ready to land.Mar 27 2023, 16:17

Closed by commit rABC9514a0915212: [Chronik] Index txs; add `/tx/:txid` HTTP endpoint (authored by tobias_ruck). · Explain WhyMar 27 2023, 17:32

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC9514a0915212: [Chronik] Index txs; add `/tx/:txid` HTTP endpoint.

tobias_ruck mentioned this in D13564: [Chronik] Remove `Network` proto enum.Apr 4 2023, 14:06

tobias_ruck mentioned this in rABC9e7ee00a415d: [Chronik] Remove `Network` proto enum.Apr 4 2023, 15:59

Revision Contents
Changeset List

Path

Size

chronik/

chronik-db/

src/

io/

2 lines

chronik-http/

src/

17 lines

chronik-indexer/

3 lines

src/

52 lines

1 line

query/

9 lines

95 lines

chronik-lib/

src/

46 lines

chronik-proto/

proto/

74 lines

test/

functional/

171 lines

test_framework/

1 line

Diff 38912

Cargo.lock

Loading...

chronik/chronik-db/src/io/txs.rs

Loading...

chronik/chronik-http/src/server.rs

Loading...

chronik/chronik-indexer/Cargo.toml

Loading...

chronik/chronik-indexer/src/indexer.rs

Loading...

chronik/chronik-indexer/src/lib.rs

Loading...

chronik/chronik-indexer/src/query/mod.rs

Loading...

chronik/chronik-indexer/src/query/txs.rs

Loading...

chronik/chronik-lib/src/bridge.rs

Loading...

chronik/chronik-proto/proto/chronik.proto

Loading...

test/functional/chronik_tx.py

Loading...

test/functional/test_framework/blocktools.py

Loading...