Page MenuHomePhabricator
Differential D13476

[ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js
ClosedPublic
Actions

Authored by bytesofman on Mar 27 2023, 13:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC893de6000eef: [ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js
Summary

T3039

Depends on D13475

Since this repo is focused primarily on ecash, make commentary references more appropriate.

Test Plan

Confirm that changes are only to comments in cashaddr.js
npm test all pass

Diff Detail

Repository
rABC Bitcoin ABC
Branch
path-to-publish-ecashaddrjs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22723
Build 45066: Build Diff
Build 45065: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 27 2023, 13:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2023, 13:02
bytesofman requested review of this revision.Mar 27 2023, 13:02
Harbormaster completed remote builds in B22723: Diff 38919.Mar 27 2023, 13:02
bytesofman added a child revision: D13477: [ecashaddrjs] Update licensing refs.Mar 27 2023, 13:07
Fabien requested changes to this revision.Mar 27 2023, 15:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/ecashaddrjs/src/cashaddr.js
28

The same apply in other places

140
This revision now requires changes to proceed.Mar 27 2023, 15:28
bytesofman updated this revision to Diff 38927.Mar 27 2023, 15:52

Respond to feedback + typo fix

Harbormaster completed remote builds in B22730: Diff 38927.Mar 27 2023, 15:52
Fabien accepted this revision.Mar 27 2023, 16:16
This revision is now accepted and ready to land.Mar 27 2023, 16:16
Closed by commit rABC893de6000eef: [ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js (authored by bytesofman). · Explain WhyMar 27 2023, 16:23
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC893de6000eef: [ecashaddrjs] Change comment references to bitcoincash: to ecash: in cashaddr.js.

Revision Contents
Changeset List

PathSize
web/
ecashaddrjs/
src/
14 lines

Diff 38919

View Options

web/ecashaddrjs/src/cashaddr.js

Loading...