Differential D13231
[lint] add the flynt linter for python f-strings Authored by PiRK on Mar 3 2023, 13:46.
Details
Convert Python code from "%-formatted" and .format(...) strings into f-strings Remove existing conversion script that only handles %-formatted strings. Performance impact: Before: $ time arc lint --everything real 2m15,395s user 9m59,264s sys 1m8,720s After: $ time arc lint --everything real 2m14,881s user 10m6,171s sys 1m8,421s Add a few %-formatted "...".format() strings in a functional test, and check that arc lint fixes them. arc lint --everything
Diff Detail
Event TimelineComment Actions fix stuff (fix extra newline added by flynt to stdout, remove the old string formatting linter which interferes with the new one) Comment Actions use --stdout option (available in new release 0.78) instead of passing data to stdin to trigger this behavior Simplify trimming of extra newlines. Comment Actions This is missing a few things:
Question: how much duration time does it adds/removes to arc lint vs the previous linter ? Comment Actions update contributing.md and install-dependencies-bullseye.sh The summary has been updated to show timing data before and after. The new tool is neither significantly faster nor slower than the previous script. |