[Chronik] Add `Default` derive to ffi structs in `chronik-bridge`
ClosedPublic
Actions

Authored by tobias_ruck on Mar 29 2023, 17:13.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC91bd7476d68e: [Chronik] Add `Default` derive to ffi structs in `chronik-bridge`

Summary

Having a default derive makes it much easier to write tests for these structs. Also sort the derives alphabetically while we're at it.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-ffi-derives

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22807
Build 45234: Build Diff	build-chronik
Build 45233: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Mar 29 2023, 17:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2023, 17:13

tobias_ruck requested review of this revision.Mar 29 2023, 17:13

Harbormaster completed remote builds in B22807: Diff 39018.Mar 29 2023, 17:30

tobias_ruck added a child revision: D13487: [Chronik] Add `Group` and `GroupHistoryReader/-Writer` to index the tx history of a group.Mar 29 2023, 17:43

Fabien accepted this revision.Mar 29 2023, 19:32

This revision is now accepted and ready to land.Mar 29 2023, 19:32

Closed by commit rABC91bd7476d68e: [Chronik] Add `Default` derive to ffi structs in `chronik-bridge` (authored by tobias_ruck). · Explain WhyMar 29 2023, 19:54

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC91bd7476d68e: [Chronik] Add `Default` derive to ffi structs in `chronik-bridge`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-bridge/

src/

ffi.rs

14 lines

Diff 39018

View Options

chronik/chronik-bridge/src/ffi.rs

[Chronik] Add `Default` derive to ffi structs in `chronik-bridge`ClosedPublicActions