[arc lint] Add alias-server to linter
AbandonedPublic
Actions

Authored by bytesofman on Mar 29 2023, 13:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

T3060

Test Plan

arc lint returns ok
type let status at top of web/alias-server/index.js
arc lint returns an issue

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22847
Build 45314: Build Diff	alias-server-tests
Build 45313: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 29 2023, 13:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2023, 13:55

bytesofman requested review of this revision.Mar 29 2023, 13:55

Harbormaster completed remote builds in B22805: Diff 39016.Mar 29 2023, 13:55

bytesofman added a child revision: D13497: [alias-server] Linting current state of repo.Mar 29 2023, 17:10

rebase

Harbormaster completed remote builds in B22847: Diff 39066.Mar 30 2023, 15:45

Please run arc lint --everything, check everything is OK and add it to the test plan.
Linting a single file doesn't indicate that all the files are passing the linter with no issue.

This revision now requires changes to proceed.Mar 30 2023, 17:27

OK I see you did in the t follow up.
You should reverse the order: first fix the linting issues, then enable a linter that would make sure the files will remain consistent across the project.
Doing it otherwise lets the repo in an undefined state.

Fabien mentioned this in D13497: [alias-server] Linting current state of repo.Mar 30 2023, 17:30

revert .arclint addition; lint everything here

Harbormaster completed remote builds in B22850: Diff 39070.Mar 30 2023, 17:41

Abandoning + rebuilding as applying all of these changes in part one messed up the rebase in part 2

See D13509