Page MenuHomePhabricator

[Cashtab] Deprecate husky
ClosedPublic

Authored by bytesofman on Mar 30 2023, 23:20.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC9af258720e4e: [Cashtab] Deprecate husky
Summary

T3068

Husky is interfering with other javascript repos in the monorepo (annoying to dev on more than one as it tries to run changed cashtab unit tests, of which there are none).

The implementation was already a bit forced due to monorepo. Husky is not the right tool here.

The snapshot situation is annoying but it is caught by CI and husky does not prevent snapshot errors 100% of the time. Need a better approach.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-husky
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22858
Build 45336: Build Diffcashtab-tests
Build 45335: arc lint + arc unit