Paths

Table of Contentst

Differential D13533

[Chronik] Add `ScriptVariant` and `ScriptType`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 1 2023, 23:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5e3e2c388afd: [Chronik] Add `ScriptVariant` and `ScriptType`

Summary

This allows us parsing which kind of script the user wants to query, and the associated payload, like a hash or pubkey.

We currently only support P2PKH, P2SH and P2PK, as these are the only ones widely used. Other types of scripts can be queried using the Other script type.

There's no OP_RETURN variant, as we don't index the tx history nor the UTXOs of OP_RETURN scripts.

Depends on D13537.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-script-variant

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22894
Build 45408: Build Diff	build-chronik
Build 45407: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 1 2023, 23:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2023, 23:12

tobias_ruck requested review of this revision.Apr 1 2023, 23:12

Harbormaster completed remote builds in B22894: Diff 39131.Apr 1 2023, 23:24

Fabien requested changes to this revision.Apr 3 2023, 10:19

Fabien added inline comments.

chronik/bitcoinsuite-core/src/script/variant.rs
195	Since there is support for both compressed and uncompressed pubkeys, the expected length should be either 33 or 65 and the message be more generic

This revision now requires changes to proceed.Apr 3 2023, 10:19

tobias_ruck mentioned this in D13537: [Chronik] Add `PubKeyVariant` to `bitcoinsuite-core`.Apr 3 2023, 12:48

Use PubKeyVariant, for clearer separation & better error messages.

tobias_ruck edited the summary of this revision. (Show Details)Apr 3 2023, 13:03

tobias_ruck added a parent revision: D13537: [Chronik] Add `PubKeyVariant` to `bitcoinsuite-core`.

Harbormaster completed remote builds in B22903: Diff 39149.Apr 3 2023, 13:20

tobias_ruck mentioned this in rABC5101c0ccf97f: [Chronik] Add `PubKeyVariant` to `bitcoinsuite-core`.Apr 3 2023, 15:16

Fabien accepted this revision.Apr 3 2023, 15:53

This revision is now accepted and ready to land.Apr 3 2023, 15:53

Closed by commit rABC5e3e2c388afd: [Chronik] Add `ScriptVariant` and `ScriptType` (authored by tobias_ruck). · Explain WhyApr 3 2023, 17:10

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC5e3e2c388afd: [Chronik] Add `ScriptVariant` and `ScriptType`.

Revision Contents
Changeset List

Path

Size

chronik/

bitcoinsuite-core/

src/

script/

mod.rs

2 lines

variant.rs

210 lines

Diff 39131

View Options

chronik/bitcoinsuite-core/src/script/mod.rs