Page MenuHomePhabricator
Differential D13544

[Chronik] Add `ScriptGroup` to group txs by script
ClosedPublic
Actions

Authored by tobias_ruck on Apr 3 2023, 17:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6bd5d170cf6e: [Chronik] Add `ScriptGroup` to group txs by script
Summary

An implementation of Group for grouping by script.

We cannot use ffi::compress_script directly here, as the tests can't link against that, so instead it is a field in ScriptGroup.

We also remove the chronik-bridge dependency as we don't need it.

Test Plan

ninja check-crates

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-script-group
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22921
Build 45462: Build Diffbuild-chronik
Build 45461: arc lint + arc unit

Event Timeline

tobias_ruck requested review of this revision.Apr 3 2023, 17:09
tobias_ruck created this revision.
Harbormaster completed remote builds in B22921: Diff 39171.Apr 3 2023, 17:22
Fabien requested changes to this revision.Apr 4 2023, 08:17
Fabien added inline comments.
chronik/chronik-db/Cargo.toml
16

That doesn't belong to this diff ?

This revision now requires changes to proceed.Apr 4 2023, 08:17
tobias_ruck updated this revision to Diff 39207.Apr 4 2023, 09:53

split out removal of chronik-bridge dependency

Fabien accepted this revision.Apr 4 2023, 10:01
This revision is now accepted and ready to land.Apr 4 2023, 10:01
Harbormaster completed remote builds in B22944: Diff 39207.Apr 4 2023, 10:56
Closed by commit rABC6bd5d170cf6e: [Chronik] Add `ScriptGroup` to group txs by script (authored by tobias_ruck). · Explain WhyApr 4 2023, 11:27
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC6bd5d170cf6e: [Chronik] Add `ScriptGroup` to group txs by script.

Revision Contents
Changeset List

PathSize
chronik/
chronik-db/
2 lines
src/
2 lines
groups/
9 lines
156 lines
1 line

Diff 39171

View Options

Cargo.lock

Loading...
View Options

chronik/chronik-db/Cargo.toml

Loading...
View Options

chronik/chronik-db/src/db.rs

Loading...
View Options

chronik/chronik-db/src/groups/mod.rs

Loading...
View Options

chronik/chronik-db/src/groups/script.rs

Loading...
View Options

chronik/chronik-db/src/lib.rs

Loading...