T2972
Depends on D13584
Add new function to make configurable API call to coingecko for fiat price information
Include unit tests for mock responses and a new script, npm run getPrices, to test the function with a real API call
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCdd4c0e446e81: [herald] add function to get crypto price info
npm i
npm test
npm run getPrices and expected price info is logged to console
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- tg-bot-price-fetch
- Lint
Lint Errors Severity Location Code Message Error apps/ecash-herald/scripts/getCoingeckoPrices.js:2 ESLINT no-unused-vars Error apps/ecash-herald/scripts/getCoingeckoPrices.js:23 ESLINT no-undef - Unit
No Test Coverage - Build Status
Buildable 23009 Build 45638: Build Diff ecash-herald-tests Build 45637: arc lint + arc unit
Event Timeline
| apps/ecash-herald/scripts/getPrices.js | ||
|---|---|---|
| 9 ↗ | (On Diff #39305) | no ecash here ? |
| apps/ecash-herald/src/utils.js | ||
| 38 ↗ | (On Diff #39305) | This is making the getPrices call dependent of the backend price provider. I you want to implement a fallback, that will be a problem. |
| apps/ecash-herald/src/utils.js | ||
|---|---|---|
| 38 ↗ | (On Diff #39305) | renamed the function to getCoingeckoPrices Another price API would probably have have its own formatting and url intricacies to deal with. imo more robust to add a fallback as a distinct function if we decide to add one. That way, if getCoingeckoPrices returns false, the app can try something else like getCoinmarketcapPrices. Or not. Most likely there will not be a fallback implemented, but if there is, this should be dealt with at that time. For the first implementation, the app simply will not render the price if coinGeckoPrices is false, which is acceptable behavior for the telegram bot. (to be next diff) |