Page MenuHomePhabricator
Differential D13599

[alias-server] Chronik functions take chronik as a param to support future mocking
ClosedPublic
Actions

Authored by bytesofman on Apr 6 2023, 13:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5e593fe5910b: [alias-server] Chronik functions take chronik as a param to support future…
Summary

T3060

Depends on D13592

This diff refactors chronik calling functions to accept chronik as a param.

Will introduce a mock chronik object for unit tests of chronik functions.

Test Plan

npm test
npm run mocks and mocks are generated

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-better-startup-handling
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23032
Build 45684: Build Diffalias-server-tests
Build 45683: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 6 2023, 13:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2023, 13:26
bytesofman requested review of this revision.Apr 6 2023, 13:26
Harbormaster completed remote builds in B23032: Diff 39342.Apr 6 2023, 13:27
bytesofman updated this revision to Diff 39345.Apr 6 2023, 13:30

rebase

Harbormaster completed remote builds in B23035: Diff 39345.Apr 6 2023, 13:31
Fabien added a subscriber: Fabien.Apr 6 2023, 14:20
Fabien added inline comments.
apps/alias-server/scripts/generateMocks.js
23 ↗(On Diff #39345)

remove

apps/alias-server/test/chronikTests.js
34 ↗(On Diff #39345)

I don't understand how this work, can you explain why the test doesn't crash ?

bytesofman added a child revision: D13602: [alias-server] replace optionalMocks param with mocked instance of chronik.Apr 6 2023, 14:39
bytesofman updated this revision to Diff 39352.Apr 6 2023, 14:42
bytesofman marked an inline comment as done.

remove console.log(chronik)

apps/alias-server/test/chronikTests.js
34 ↗(On Diff #39345)

See just pushed up diff, D13602

Before chronik is mocked, I am using this optionalMocks param as a sort of isUnitTest flag. It modifies the logic of getUnprocessedTxs such that it does not use chronik for anything.

Fabien accepted this revision.Apr 6 2023, 14:52
This revision is now accepted and ready to land.Apr 6 2023, 14:52
Harbormaster completed remote builds in B23040: Diff 39352.Apr 6 2023, 14:53
Closed by commit rABC5e593fe5910b: [alias-server] Chronik functions take chronik as a param to support future… (authored by bytesofman). · Explain WhyApr 6 2023, 15:47
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC5e593fe5910b: [alias-server] Chronik functions take chronik as a param to support future….

Revision Contents
Changeset List

PathSize
apps/
alias-server/
scripts/
5 lines
src/
26 lines
test/
4 lines

Diff 39342

View Options

apps/alias-server/scripts/generateMocks.js

Loading...
View Options

apps/alias-server/src/chronik.js

Loading...
View Options

apps/alias-server/test/chronikTests.js

Loading...