Page MenuHomePhabricator
Differential D13631

[alias-server] Get block height in handleBlockConnected
ClosedPublic
Actions

Authored by bytesofman on Apr 8 2023, 13:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7322e1aa55af: [alias-server] Get block height in handleBlockConnected
Summary

T3060

Depends on D13630

Get tipHeight in handleBlockConnected function for later use in processing valid aliases

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23136
Build 45892: Build Diff
Build 45891: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 8 2023, 13:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2023, 13:38
bytesofman requested review of this revision.Apr 8 2023, 13:38
Harbormaster completed remote builds in B23103: Diff 39428.Apr 8 2023, 13:39
bytesofman updated this revision to Diff 39429.Apr 8 2023, 13:39

Updating todo comments

bytesofman added a child revision: D13632: [alias-server] Patch error in name of test file.Apr 8 2023, 13:40
Harbormaster completed remote builds in B23104: Diff 39429.Apr 8 2023, 13:40
Fabien requested changes to this revision.Apr 9 2023, 08:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/alias-server/test/websocketTests.js
80 ↗(On Diff #39429)

WTF ???

85 ↗(On Diff #39429)

Why do you declare a 550 lines mocked block when all you need is this ?

This revision now requires changes to proceed.Apr 9 2023, 08:49
bytesofman added a child revision: D13633: [alias-server] Add avalancheCheckWaitInterval as a parameter to prevent 10s delays in unit tests.Apr 10 2023, 14:17
bytesofman removed a child revision: D13632: [alias-server] Patch error in name of test file.
bytesofman updated this revision to Diff 39470.Apr 10 2023, 14:24

Removing unused giant block mock

Harbormaster completed remote builds in B23136: Diff 39470.Apr 10 2023, 14:24
bytesofman updated this revision to Diff 39475.Apr 10 2023, 14:54

rebase

Harbormaster completed remote builds in B23141: Diff 39475.Apr 10 2023, 14:54
Fabien accepted this revision.Apr 10 2023, 19:03
This revision is now accepted and ready to land.Apr 10 2023, 19:03
Closed by commit rABC7322e1aa55af: [alias-server] Get block height in handleBlockConnected (authored by bytesofman). · Explain WhyApr 12 2023, 14:20
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC7322e1aa55af: [alias-server] Get block height in handleBlockConnected.

Revision Contents
Changeset List

PathSize
apps/
alias-server/
src/
29 lines
test/
8 lines
15 lines

Diff 39470

View Options

apps/alias-server/src/events.js

Loading...
View Options

apps/alias-server/test/eventsTests.js

Loading...
View Options

apps/alias-server/test/websocketTests.js

Loading...