[monorepo prettier] Prettier should ignore yml files
ClosedPublic
Actions

Authored by bytesofman on Apr 10 2023, 16:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8f6a3bc7e088: [monorepo prettier] Prettier should ignore yml files

Summary

T3044

prettier should not auto lint yml files, this is handled separately

Test Plan

If you are using vscode, then saving a changed yml file will auto-apply prettier rules. With this change, that behavior should not happen. I'm not sure about other IDEs.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

prettier-ignore-yml

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23173
Build 45965: Build Diff
Build 45964: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 10 2023, 16:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 10 2023, 16:45

bytesofman requested review of this revision.Apr 10 2023, 16:45

Harbormaster completed remote builds in B23173: Diff 39508.Apr 10 2023, 16:45

bytesofman mentioned this in D13654: [ecashaddrjs] Testing to CI using template.Apr 10 2023, 16:45

Fabien accepted this revision.Apr 10 2023, 19:14

This revision is now accepted and ready to land.Apr 10 2023, 19:14

Closed by commit rABC8f6a3bc7e088: [monorepo prettier] Prettier should ignore yml files (authored by bytesofman). · Explain WhyApr 10 2023, 22:29

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC8f6a3bc7e088: [monorepo prettier] Prettier should ignore yml files.

Revision Contents
Changeset List

Path

Size

.prettierignore

3 lines

Diff 39508

View Options

[monorepo prettier] Prettier should ignore yml filesClosedPublicActions