Page MenuHomePhabricator

[avalanche] Rename variables shadowing builtins in avatools
ClosedPublic

Authored by sdulfari on Apr 11 2023, 06:56.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC72a3ee627ac7: [avalanche] Rename variables shadowing builtins in avatools
Summary

Shadowing builtins can lead to unexpected behavior. This is one of many steps to integrating flake8-builtins so we do not have to worry about this in the future.

Test Plan
./test/functional/test_runner.py abc_*
pip3 install flake8-builtins
flake8 test/functional/test_framework/avatools.py  # verify no A00x errors

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avatools-shadowed-builtins
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23189
Build 45997: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 45996: arc lint + arc unit