Page MenuHomePhabricator
Differential D13665

depends: Use more legible qmake commands in qt package
ClosedPublic
Actions

Authored by PiRK on Apr 11 2023, 13:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6bab00bf874c: depends: Use more legible qmake commands in qt package
Summary

depends: Do not set build_subdir for qt package

This change makes the next commit possible without exporting the PATH
variable.

depends: Use more legible qmake commands in qt package
This change gets rid of multiple ../ that makes reasoning about the
script and its maintaining much easier.

Co-authored-by: fanquake <fanquake@gmail.com>

See D830 for the differences in the source material.

This is a backport of core#20673

Depends on D13664

Test Plan

gitian builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qt_mk
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23196
Build 46011: Build Diff
Build 46010: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 11 2023, 13:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 13:13
PiRK requested review of this revision.Apr 11 2023, 13:13
teamcity edited the summary of this revision. (Show Details)Apr 11 2023, 13:13
Harbormaster completed remote builds in B23196: Diff 39539.Apr 11 2023, 13:13
PiRK edited the summary of this revision. (Show Details)Apr 11 2023, 13:15
PiRK added a parent revision: D13664: depends: Drop workaround for a fixed bug in Qt build system.

@bot gitian-linux

teamcity awarded a token.Apr 11 2023, 13:15
Fabien accepted this revision.Apr 11 2023, 14:17
This revision is now accepted and ready to land.Apr 11 2023, 14:17
PiRK added a comment.Apr 11 2023, 14:31

@bot gitian-win gitian-osx

teamcity updated a token.Apr 11 2023, 14:31
Closed by commit rABC6bab00bf874c: depends: Use more legible qmake commands in qt package (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyApr 11 2023, 17:03
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6bab00bf874c: depends: Use more legible qmake commands in qt package.

Revision Contents
Changeset List

PathSize
depends/
packages/
29 lines

Diff 39539

View Options

depends/packages/qt.mk

Loading...