This restricts the access to website previews to ABC members only. This policy might be relaxed in the future.
Depends on D13661.
Differential D13663
[buildbot] Disallow non ABC members from summoning builds with a docker configuration Fabien on Apr 11 2023, 09:45. Authored by Tags None Subscribers None
Details
This restricts the access to website previews to ABC members only. This policy might be relaxed in the future. Depends on D13661. ./contrib/teamcity/build-configurations.py check-buildbot
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (check-buildbot) failed.
Failed tests logs: ====== test_endpoint_triggerCI.EndpointTriggerCITestCase.test_triggerCI_some_build_queued ====== test_endpoint_triggerCI.py:319 (EndpointTriggerCITestCase.test_triggerCI_some_build_queued) self = <test.test_endpoint_triggerCI.EndpointTriggerCITestCase testMethod=test_triggerCI_some_build_queued> def test_triggerCI_some_build_queued(self): def assert_teamcity_queued_builds(comments, queued_builds): # Default user is an ABC member in set_transaction_return_value self.set_transaction_return_value(comments) response = self.call_endpoint() expected_calls = [ call( "BitcoinABC_BitcoinAbcStaging", f"refs/tags/phabricator/diff/{self.diff_id}", properties=[{ 'name': 'env.ABC_BUILD_NAME', 'value': build_id, }] ) for build_id in queued_builds ] self.teamcity.trigger_build.assert_has_calls( expected_calls, any_order=True) self.assertEqual(response.status_code, 200) # ABC user, 1 comment targeting the bot with 1 build > assert_teamcity_queued_builds( [ "@bot build-1", ], [ "build-1", ], PHID_user="" ) E TypeError: assert_teamcity_queued_builds() got an unexpected keyword argument 'PHID_user' test_endpoint_triggerCI.py:341: TypeError Each failure log is accessible here: |