Page MenuHomePhabricator
Differential D13661

[buildbot] Extract the build configuration retrieval and parsing to its own function
ClosedPublic
Actions

Authored by Fabien on Apr 11 2023, 08:40.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc78fb6c5634c: [buildbot] Extract the build configuration retrieval and parsing to its own…
Summary

This will be called from another place in another diff. There is no change in behavior.

Test Plan
./contrib/teamcity/build-configurations.py check-buildbot

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 11 2023, 08:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 08:40
Fabien requested review of this revision.Apr 11 2023, 08:40
Harbormaster completed remote builds in B23191: Diff 39532.Apr 11 2023, 08:41
PiRK accepted this revision.Apr 11 2023, 08:53
PiRK added a subscriber: PiRK.
PiRK added inline comments.
contrib/buildbot/server.py
172 ↗(On Diff #39532)

optional nit: f-string and line splitting

I need to experiment with the line-length option for flynt.

This revision is now accepted and ready to land.Apr 11 2023, 08:53
Fabien added a child revision: D13663: [buildbot] Disallow non ABC members from summoning builds with a docker configuration.Apr 11 2023, 09:45
Closed by commit rABCc78fb6c5634c: [buildbot] Extract the build configuration retrieval and parsing to its own… (authored by Fabien). · Explain WhyApr 11 2023, 11:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc78fb6c5634c: [buildbot] Extract the build configuration retrieval and parsing to its own….

Revision Contents
Changeset List

PathSize
contrib/
buildbot/
58 lines

Diff 39535

View Options

contrib/buildbot/server.py

Loading...