[test framework] use an Enum instead of typing.Literal for PortName
ClosedPublic
Actions

Authored by PiRK on Apr 11 2023, 16:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC348a0e139fc8: [test framework] use an Enum instead of typing.Literal for PortName

Summary

typing.Literal is new in Python 3.8. We still support Python 3.6 and 3.7.

See D13659#304051

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 11 2023, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2023, 16:18

PiRK requested review of this revision.Apr 11 2023, 16:18

PiRK edited the summary of this revision. (Show Details)Apr 11 2023, 16:20

reduce verbosity a bit by using integers instead of enum.auto()

Harbormaster completed remote builds in B23205: Diff 39554.Apr 11 2023, 17:13

Harbormaster completed remote builds in B23206: Diff 39555.Apr 11 2023, 17:19

Fabien accepted this revision.Apr 11 2023, 20:13

This revision is now accepted and ready to land.Apr 11 2023, 20:13

Closed by commit rABC348a0e139fc8: [test framework] use an Enum instead of typing.Literal for PortName (authored by PiRK). · Explain WhyApr 12 2023, 11:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC348a0e139fc8: [test framework] use an Enum instead of typing.Literal for PortName.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

util.py

23 lines

Diff 39588

View Options

test/functional/test_framework/util.py

[test framework] use an Enum instead of typing.Literal for PortNameClosedPublicActions