Paths

Table of Contentst

Differential D13716

[herald] Remove unused flag from `parsedTx` data
ClosedPublic
Actions

Authored by bytesofman on Apr 14 2023, 03:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa0a0bfe88d67: [herald] Remove unused flag from `parsedTx` data

Summary

T2972

Depends on D13715

isTokenTx is a useful variable as a private flag in parseTx. It isn't used outside of the function so is not needed in the parsedTx model.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tg-function-to-utils

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23309
Build 46237: Build Diff	ecash-herald-tests
Build 46236: arc lint + arc unit

Event Timeline

bytesofman created this revision.Apr 14 2023, 03:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2023, 03:36

updating comment

Harbormaster completed remote builds in B23308: Diff 39722.Apr 14 2023, 03:37

Harbormaster completed remote builds in B23309: Diff 39723.

Fabien accepted this revision.Apr 14 2023, 13:25

This revision is now accepted and ready to land.Apr 14 2023, 13:25

Closed by commit rABCa0a0bfe88d67: [herald] Remove unused flag from `parsedTx` data (authored by bytesofman). · Explain WhyApr 14 2023, 21:53

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCa0a0bfe88d67: [herald] Remove unused flag from `parsedTx` data.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

4 lines

test/

mocks/

blocks.js

Diff 39723

View Options

apps/ecash-herald/src/parse.js