Differential D13748

[lint] Fix variables shadowing python builtins in linearize-data.py
ClosedPublic
Actions

Authored by sdulfari on Apr 20 2023, 18:35.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC90bf9c092471: [lint] Fix variables shadowing python builtins in linearize-data.py

Summary

Shadowing builtins can lead to unexpected behavior. Continuing work from D13740

Test Plan

cp example-linearize.cfg linearize.cfg  # Make changes as necessary
./linearize-hashes.py linearize.cfg > hashlist.txt
./linearize-data.py linearize.cfg

Diff Detail

Repository

rABC Bitcoin ABC

Branch

a001-linearize-data

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23386
Build 46391: Build Diff
Build 46390: arc lint + arc unit

Event Timeline

sdulfari created this revision.Apr 20 2023, 18:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2023, 18:35

sdulfari requested review of this revision.Apr 20 2023, 18:35

Harbormaster completed remote builds in B23386: Diff 39837.Apr 20 2023, 18:35

sdulfari added a child revision: D13751: [lint] Fix remaining variables shadowing python builtins and enable detection of shadowed variables going forward.Apr 20 2023, 19:52

PiRK accepted this revision.Apr 21 2023, 06:23

This revision is now accepted and ready to land.Apr 21 2023, 06:23

Closed by commit rABC90bf9c092471: [lint] Fix variables shadowing python builtins in linearize-data.py (authored by sdulfari). · Explain WhyApr 21 2023, 15:30

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC90bf9c092471: [lint] Fix variables shadowing python builtins in linearize-data.py.

Revision Contents
Changeset List

Path

Size

contrib/

linearize/

linearize-data.py

12 lines

Diff 39837

View Options

contrib/linearize/linearize-data.py

[lint] Fix variables shadowing python builtins in linearize-data.pyClosedPublicActions