Page MenuHomePhabricator
Differential D13791

[Chronik] Add `Script::iter_ops` and `ScriptOpIter`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 26 2023, 14:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC007abbfe3a93: [Chronik] Add `Script::iter_ops` and `ScriptOpIter`
Summary

Iterates over the operations in a Script. This can either be a single opcode, or an opcode which pushes some data following it in the bytecode.

This is important for parsing scripts, e.g. for SLP.

Test Plan

ninja check-crates

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-script-iter_ops
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23481
Build 46581: Build Diffbuild-chronik
Build 46580: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 26 2023, 14:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2023, 14:38
tobias_ruck requested review of this revision.Apr 26 2023, 14:38
Harbormaster completed remote builds in B23480: Diff 39974.Apr 26 2023, 14:38
tobias_ruck updated this revision to Diff 39975.Apr 26 2023, 14:40

fix lint

Harbormaster completed remote builds in B23481: Diff 39975.Apr 26 2023, 14:55
Fabien added inline comments.Apr 27 2023, 13:27
chronik/bitcoinsuite-core/src/script/iter.rs
36

You probably should return an error here. AFAICT this could occur of parsing a push with not enough data remaining, in which case you get a truncated result and it's invalid anyway

tobias_ruck updated this revision to Diff 40049.Apr 27 2023, 23:44

make ScriptOpIter::next code more readable

Harbormaster completed remote builds in B23533: Diff 40049.Apr 28 2023, 00:20
Fabien accepted this revision.Apr 28 2023, 12:16
This revision is now accepted and ready to land.Apr 28 2023, 12:16
Closed by commit rABC007abbfe3a93: [Chronik] Add `Script::iter_ops` and `ScriptOpIter` (authored by tobias_ruck). · Explain WhyApr 29 2023, 17:06
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC007abbfe3a93: [Chronik] Add `Script::iter_ops` and `ScriptOpIter`.

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-core/
src/
script/
41 lines
4 lines
47 lines
51 lines

Diff 39975

View Options

chronik/bitcoinsuite-core/src/script/iter.rs

Loading...
View Options

chronik/bitcoinsuite-core/src/script/mod.rs

Loading...
View Options

chronik/bitcoinsuite-core/src/script/op.rs

Loading...
View Options

chronik/bitcoinsuite-core/src/script/script.rs

Loading...