Page MenuHomePhabricator
Differential D13830

[Chronik] Add `/blocks/:start_height/:end_height` HTTP endpoint
ClosedPublic
Actions

Authored by tobias_ruck on Apr 29 2023, 21:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9be77939e133: [Chronik] Add `/blocks/:start_height/:end_height` HTTP endpoint
Summary

Allows querying a long range of blocks by start and end height (inclusive).

The limit of 500 may seem high, but this is a very cheap call with no extra calls to the DB, so this is fine.

Depends on D13829.

Test Plan

ninja && ./test/functional/test_runner.py chronik_blocks

Diff Detail

Event Timeline

tobias_ruck created this revision.Apr 29 2023, 21:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2023, 21:07
tobias_ruck requested review of this revision.Apr 29 2023, 21:07
Harbormaster completed remote builds in B23573: Diff 40106.Apr 29 2023, 21:20
tobias_ruck added a child revision: D13831: [Chronik] Add `load_raw_tx` to chronik-bridge.Apr 29 2023, 21:59
Fabien requested changes to this revision.May 1 2023, 10:30
Fabien added inline comments.
test/functional/chronik_blocks.py
15 ↗(On Diff #40106)
52 ↗(On Diff #40106)

Please also add:

assert_equal(chronik.blocks(0, 0).ok(), pb.Blocks(blocks=[genesis_info]))

To check for >= vs > issues

This revision now requires changes to proceed.May 1 2023, 10:30
tobias_ruck updated this revision to Diff 40119.May 1 2023, 15:33

Rename test class, add some missing cases

Fabien accepted this revision.May 1 2023, 15:42
This revision is now accepted and ready to land.May 1 2023, 15:42
This revision was landed with ongoing or failed builds.May 1 2023, 15:52
Closed by commit rABC9be77939e133: [Chronik] Add `/blocks/:start_height/:end_height` HTTP endpoint (authored by tobias_ruck). · Explain Why
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC9be77939e133: [Chronik] Add `/blocks/:start_height/:end_height` HTTP endpoint.
Harbormaster completed remote builds in B23585: Diff 40119.May 1 2023, 15:53

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
10 lines
chronik-indexer/
src/
query/
68 lines
chronik-proto/
proto/
6 lines
test/
functional/
78 lines
test_framework/
chronik/
3 lines

Diff 40119

View Options

chronik/chronik-http/src/server.rs

Loading...
View Options

chronik/chronik-indexer/src/query/blocks.rs

Loading...
View Options

chronik/chronik-proto/proto/chronik.proto

Loading...
View Options

test/functional/chronik_blocks.py

Loading...
View Options

test/functional/test_framework/chronik/client.py

Loading...