Differential D13842

[linter] Avoid unreachable code in shell scripts
ClosedPublic
Actions

Authored by Fabien on May 2 2023, 14:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa2b104d4d8eb: [linter] Avoid unreachable code in shell scripts

Summary

Reported by Shellcheck SC2317. Note that some of the reports are false positive and has been explicitely ignored.

Test Plan

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_shellcheck

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23598
Build 46810: Build Diff
Build 46809: arc lint + arc unit

Event Timeline

Fabien created this revision.May 2 2023, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2023, 14:45

Fabien requested review of this revision.May 2 2023, 14:45

Harbormaster completed remote builds in B23598: Diff 40146.May 2 2023, 14:45

PiRK accepted this revision.May 2 2023, 15:22

This revision is now accepted and ready to land.May 2 2023, 15:22

Closed by commit rABCa2b104d4d8eb: [linter] Avoid unreachable code in shell scripts (authored by Fabien). · Explain WhyMay 2 2023, 15:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa2b104d4d8eb: [linter] Avoid unreachable code in shell scripts.

Revision Contents
Changeset List

Path

Size

contrib/

devtools/

bitcoind-exit-on-log.sh

1 line

source-control-tools/

autopatch.sh

3 lines

Diff 40146

View Options

contrib/devtools/bitcoind-exit-on-log.sh