reset m_best_fork_tip if the fork becomes the main chain
ClosedPublic
Actions

Authored by PiRK on May 17 2023, 08:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4459a350623b: reset m_best_fork_tip if the fork becomes the main chain

Summary

This fixes a spurious "CheckForkWarningConditions: Warning: Large fork found" log when a block is unparked resulting in m_best_fork_tip now being added back to the main chain. This warning kept being logged on every new block even though the fork was resolved.

It also adds a functional test for that log message which was previously untested.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

_fork_warning_fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23727
Build 47065: Build Diff	lint-circular-dependencies · build-diff · build-clang · build-clang-tidy · build-debug · build-without-wallet
Build 47064: arc lint + arc unit

Event Timeline

PiRK created this revision.May 17 2023, 08:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2023, 08:45

PiRK requested review of this revision.May 17 2023, 08:45

PiRK added a child revision: D13910: rename abc-parkedchain.py -> abc_feature_parkedchain.py.May 17 2023, 08:48

PiRK edited the summary of this revision. (Show Details)May 17 2023, 08:52

PiRK retitled this revision from remove spurious warning about large fork if the fork tip is back on the active chain to reset m_best_fork_tip if the fork becomes the main chain.May 17 2023, 08:57

PiRK edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B23727: Diff 40334.May 17 2023, 09:03

Fabien accepted this revision.May 17 2023, 12:47

This revision is now accepted and ready to land.May 17 2023, 12:47

Closed by commit rABC4459a350623b: reset m_best_fork_tip if the fork becomes the main chain (authored by PiRK). · Explain WhyMay 17 2023, 13:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4459a350623b: reset m_best_fork_tip if the fork becomes the main chain.