Differential D13937

Remove the mempool internal wellington upgrade latch
ClosedPublic
Actions

Authored by Fabien on May 25 2023, 14:34.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC177174f173e3: Remove the mempool internal wellington upgrade latch

Summary

Treat as it is always on now that wellington is activated. This pulls several required cleanups, but only the minimal subset is part of this diff: more clean ups will be added as follow ups.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

wellington_cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23803
Build 47216: Build Diff	build-diff · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-debug · build-clang · build-bench
Build 47215: arc lint + arc unit

Event Timeline

Fabien created this revision.May 25 2023, 14:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2023, 14:34

Fabien requested review of this revision.May 25 2023, 14:34

Fabien retitled this revision from Remove the mempool wellington upgrade flag to Remove the mempool internal wellington upgrade latch.May 25 2023, 14:40

Harbormaster completed remote builds in B23797: Diff 40433.May 25 2023, 14:58

So many red lines ❤️

Looks great, except for two unused variables that can be removed in mempool_packages

test/functional/mempool_packages.py
52–53 ↗	(On Diff #40433)

PiRK requested changes to this revision.May 25 2023, 16:42

This revision now requires changes to proceed.May 25 2023, 16:42

Make good use of the ancestor_size and ancestor_fees variables in mempool_packages.py

Harbormaster completed remote builds in B23803: Diff 40441.May 25 2023, 20:18

Dedup initialization

PiRK accepted this revision.May 26 2023, 12:42

This revision is now accepted and ready to land.May 26 2023, 12:42

Harbormaster completed remote builds in B23810: Diff 40450.May 26 2023, 12:56

Closed by commit rABC177174f173e3: Remove the mempool internal wellington upgrade latch (authored by Fabien). · Explain WhyMay 26 2023, 14:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC177174f173e3: Remove the mempool internal wellington upgrade latch.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

5 lines

src/

bench/

45 lines

interfaces/

10 lines

node/

38 lines

test/

activation_tests.cpp

50 lines

mempool_tests.cpp

411 lines

35 lines

192 lines

22 lines

wallet/

16 lines

14 lines

test/

functional/

abc_mempool_chainedtx.py

82 lines

mempool_package_limits.py

mempool_packages.py

243 lines

mempool_updatefromblock.py

29 lines

rpc_deprecated.py

24 lines

wallet_basic.py

84 lines

Diff 40441

doc/release-notes.md

Loading...

src/bench/chained_tx.cpp

Loading...

src/interfaces/chain.h

Loading...

src/node/interfaces.cpp

Loading...

src/test/activation_tests.cpp

Loading...

src/test/mempool_tests.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

src/validation.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/spend.cpp

Loading...

test/functional/abc_mempool_chainedtx.py

Loading...

test/functional/mempool_package_limits.py

Loading...

test/functional/mempool_packages.py

Loading...

test/functional/mempool_updatefromblock.py

Loading...

test/functional/rpc_deprecated.py

Loading...

test/functional/wallet_basic.py

Loading...