Page MenuHomePhabricator
Differential D1473

[qa] change default number of rpc test jobs
ClosedPublic
Actions

Authored by schancel on May 31 2018, 02:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3e35da18440c: [qa] change default number of rpc test jobs
rABC3e35da18440c: [qa] change default number of rpc test jobs
Summary

As per title. Depends on D1400

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.May 31 2018, 02:19
schancel edited the summary of this revision. (Show Details)May 31 2018, 02:20
schancel added a parent revision: D1400: [qa] parallelize tests suite rather than polling subprocesses.
teamcity added a subscriber: teamcity.May 31 2018, 02:21

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 31 2018, 02:56

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2689: Diff 4044.May 31 2018, 02:56
jasonbcox added a subscriber: jasonbcox.Jun 4 2018, 16:12
jasonbcox added inline comments.
test/functional/test_runner.py
162 ↗(On Diff #4044)

This value will only be 4 with a 12-core+ processor. Is the intention to lower this value for typical 4 to 8 core processors?

jasonbcox requested changes to this revision.Jun 4 2018, 21:33

+1 on the default as we discussed in slack. The // 3 is fine since 1 job doesn't necessarily mean 1 node.

This revision now requires changes to proceed.Jun 4 2018, 21:33
schancel updated this revision to Diff 4052.Jun 4 2018, 21:33

Fix num_jobs

jasonbcox accepted this revision.Jun 4 2018, 21:34
This revision is now accepted and ready to land.Jun 4 2018, 21:34
teamcity added a comment.Jun 4 2018, 21:35

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Closed by commit rABC3e35da18440c: [qa] change default number of rpc test jobs (authored by schancel). · Explain WhyJun 4 2018, 21:37
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Jun 4 2018, 22:08

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2695: Diff 4052.Jun 4 2018, 22:08

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines

Diff 4053

View Options

test/functional/test_runner.py

Loading...