Page MenuHomePhabricator

build: fix unoptimized libraries in depends
ClosedPublic

Authored by PiRK on Jun 5 2023, 06:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC039fb20f2262: build: fix unoptimized libraries in depends
Summary

We need to append-to rather than set CXXFLAGS, otherwise we loose -O2 &
-pipe. Currently this results in zeromq being built without optimizations
at all (or whatever the compiler would default too, essentially always -O0).

Bdb is the same, for the CXX portion of its code. C code has been built
with -O2.

Boost has actually been uneffected because it receives -O3 from it's own
build flags.

Also use c++17 for protobuf

This is a backport of core#22840

Test Plan

gitian builds, guix build

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr22840
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23895
Build 47400: Build Diff
Build 47399: arc lint + arc unit