Paths

Table of Contentst

Differential D13981

[Chronik] Fix: Indexed block size is 0 when running `-chronikindex`
ClosedPublic
Actions

Authored by tobias_ruck on Jun 4 2023, 19:10.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC6d3ac59e0e54: [Chronik] Fix: Indexed block size is 0 when running `-chronikindex`

Summary

During -chronikreindex, CBlockIndex::nSize seems to be 0, and the wrong value is indexed for the block size.

This should potentially be fixed downstream (by setting nSize correctly before running the -chronikreindex loop), but for now, using ::GetSerializeSize fixes the bug.

Test Plan

ninja && ./test/functional/test_runner.py chronik_block
Use nSize in chronik_bridge.cpp instead of GetSerializeSize, now chronik_block.py should fail.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jun 4 2023, 19:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2023, 19:10

tobias_ruck requested review of this revision.Jun 4 2023, 19:10

Harbormaster completed remote builds in B23891: Diff 40579.Jun 4 2023, 19:28

Fabien accepted this revision.Jun 5 2023, 08:24

This revision is now accepted and ready to land.Jun 5 2023, 08:24

Closed by commit rABC6d3ac59e0e54: [Chronik] Fix: Indexed block size is 0 when running `-chronikindex` (authored by tobias_ruck). · Explain WhyJun 5 2023, 11:08

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC6d3ac59e0e54: [Chronik] Fix: Indexed block size is 0 when running `-chronikindex`.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik_bridge.cpp

2 lines

test/

functional/

chronik_block.py

41 lines

Diff 40593

chronik/chronik-cpp/chronik_bridge.cpp

Loading...

test/functional/chronik_block.py

Loading...