Page MenuHomePhabricator
Differential D14034

[ecash-herald] Parse cash fusion txs
ClosedPublic
Actions

Authored by bytesofman on Jun 9 2023, 21:18.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCa5b1e17c9593: [ecash-herald] Parse cash fusion txs
Summary

T2972

Depends on D14033

Support parsing cash fusion txs

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-opreturn-cleanup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24008
Build 47626: Build Diffecash-herald-tests
Build 47625: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 9 2023, 21:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 9 2023, 21:18
bytesofman requested review of this revision.Jun 9 2023, 21:18
bytesofman added a comment.Jun 9 2023, 21:18

image.png (198×533 px, 25 KB)

Harbormaster completed remote builds in B23981: Diff 40710.Jun 9 2023, 21:19
emack requested changes to this revision.Jun 10 2023, 07:30
emack added a subscriber: emack.
emack added inline comments.
apps/ecash-herald/constants/op_return.js
20 ↗(On Diff #40710)

Previous fusion txs like this and this have an OP_RETURN prefix 5920070, which is different to the one specified here. If 46555a00 is the designated fusion prefix going forward then it needs to catch these legacy txs as well, especially given the msgByBlock function where users can specify block height all the way back to genesis.

This revision now requires changes to proceed.Jun 10 2023, 07:30
bytesofman updated this revision to Diff 40742.Jun 12 2023, 17:37

Support legacy fusion prefix

Harbormaster completed remote builds in B24008: Diff 40742.Jun 12 2023, 17:46
emack accepted this revision.Jun 12 2023, 22:28
This revision is now accepted and ready to land.Jun 12 2023, 22:28
Closed by commit rABCa5b1e17c9593: [ecash-herald] Parse cash fusion txs (authored by bytesofman). · Explain WhyJun 12 2023, 22:33
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCa5b1e17c9593: [ecash-herald] Parse cash fusion txs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
constants/
2 lines
scripts/
src/
50 lines
test/
mocks/
9 lines

Diff 40742

View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/scripts/generateMocks.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/blocks.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...