Differential D14083

[ecash-herald] Remove hardcoded string from function
ClosedPublic
Actions

Authored by bytesofman on Jun 19 2023, 22:30.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCe10d09a8722d: [ecash-herald] Remove hardcoded string from function

Summary

T2972

Depends on D14082

Replace 6a with constant. Should also rename the constant, but another diff for that, used elsewhere.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Jun 19 2023, 22:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2023, 22:30

bytesofman requested review of this revision.Jun 19 2023, 22:30

Harbormaster completed remote builds in B24099: Diff 40875.Jun 19 2023, 22:32

bytesofman added a child revision: D14085: [ecash-herald] Clean up comments for fusion tx parsing.Jun 19 2023, 23:01

emack accepted this revision.Jun 19 2023, 23:31

This revision is now accepted and ready to land.Jun 19 2023, 23:31

rebase

Harbormaster completed remote builds in B24108: Diff 40886.Jun 19 2023, 23:53

Closed by commit rABCe10d09a8722d: [ecash-herald] Remove hardcoded string from function (authored by bytesofman). · Explain WhyJun 20 2023, 16:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCe10d09a8722d: [ecash-herald] Remove hardcoded string from function.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

2 lines

Diff 40899

View Options

apps/ecash-herald/src/parse.js

[ecash-herald] Remove hardcoded string from functionClosedPublicActions